fix(schematics): remove comments in collection.json #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for formly-dev failed. Built with commit 463d0bb https://app.netlify.com/sites/formly-dev/deploys/5e96f755448ffc00061a77a6 |
|
We didn't give yet to schematics what it deserves:smiley:! Thank you @cyrilletuzi! |
|
released in 5.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #2177
What is the current behavior? (You can also link to an open issue here)
None for the lib itself, crash for tools using it.
What is the new behavior (if this is a feature change)?
None for the lib itself, not crashing for tools using it.
Please check if the PR fulfills these requirements
npm run buildproduced a successful build. (Unit testing can be done by runningnpm test;)npm run lintto do this.npm run buildwill fail if there are files not linted.)