Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): fix bootstrap template repo link #369

Merged
merged 2 commits into from
May 31, 2017

Conversation

blowsie
Copy link
Contributor

@blowsie blowsie commented Feb 6, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 6, 2017

Codecov Report

Merging #369 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   92.71%   92.39%   -0.33%     
==========================================
  Files          16       15       -1     
  Lines         769      776       +7     
  Branches      198      207       +9     
==========================================
+ Hits          713      717       +4     
- Misses         56       59       +3
Impacted Files Coverage Δ
src/core/core.ts 96.87% <0%> (-3.13%) ⬇️
src/core/services/formly.config.ts 84.7% <0%> (-2.95%) ⬇️
src/core/components/formly.attributes.ts 92.85% <0%> (-0.9%) ⬇️
src/ui-bootstrap/formly.validation-message.ts 94.44% <0%> (-0.8%) ⬇️
src/core/components/formly.group.ts 90.9% <0%> (-0.76%) ⬇️
src/core/services/formly.form.builder.ts 96.42% <0%> (-0.51%) ⬇️
src/core/services/formly.validation-messages.ts 93.33% <0%> (-0.42%) ⬇️
src/core/components/formly.form.ts 89.74% <0%> (-0.13%) ⬇️
...rc/core/services/formly.single.focus.dispatcher.ts
src/core/utils.ts 96.19% <0%> (+0.07%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9d697...2a32b78. Read the comment docs.

@aitboudad
Copy link
Member

right now ng-bootstrap is located in this repo itself

@aitboudad aitboudad closed this Feb 22, 2017
@blowsie
Copy link
Contributor Author

blowsie commented May 31, 2017

@aitboudad the readme link is still broken

@aitboudad
Copy link
Member

@blowsie Material2 + Bootstrap should be part of the core not in a separate repo.
can you edit Readme ?

@blowsie
Copy link
Contributor Author

blowsie commented May 31, 2017

@aitboudad
Copy link
Member

yep, for Material2 I'm working on it right now just link to #335

@aitboudad aitboudad merged commit 03ef784 into ngx-formly:master May 31, 2017
@aitboudad
Copy link
Member

Thank you @blowsie!

@blowsie blowsie deleted the patch-1 branch May 31, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants