Skip to content

Commit

Permalink
feat: remove HttpService and CacheService
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
Removing HttpClient overload as this is definitely not something
the Angular team is looking to support. Also it's not relevant and
useful anymore thanks to state management libraries, that's why
CacheService is also removed.
  • Loading branch information
sinedied committed Mar 25, 2020
1 parent 8dbadb7 commit 99eea62
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 718 deletions.
5 changes: 2 additions & 3 deletions generators/app/templates/src/app/core/_core.module.ts
@@ -1,11 +1,10 @@
import { NgModule, Optional, SkipSelf } from '@angular/core';
import { CommonModule } from '@angular/common';
import { HTTP_INTERCEPTORS, HttpClient, HttpClientModule } from '@angular/common/http';
import { HTTP_INTERCEPTORS, HttpClientModule } from '@angular/common/http';
import { RouteReuseStrategy, RouterModule } from '@angular/router';
import { TranslateModule } from '@ngx-translate/core';

import { RouteReusableStrategy } from './route-reusable-strategy';
import { HttpService } from './http/http.service';

@NgModule({
imports: [
Expand All @@ -16,7 +15,7 @@ import { HttpService } from './http/http.service';
],
providers: [
{
provide: HttpClient,
provide: HTTP_INTERCEPTORS,
useClass: HttpService
},
{
Expand Down
3 changes: 0 additions & 3 deletions generators/app/templates/src/app/core/_index.ts
@@ -1,9 +1,6 @@
export * from './core.module';
export * from './i18n.service';
export * from './http/http.service';
export * from './http/http-cache.service';
export * from './http/api-prefix.interceptor';
export * from './http/cache.interceptor';
export * from './http/error-handler.interceptor';
export * from './route-reusable-strategy';
export * from './logger.service';
Expand Down
115 changes: 0 additions & 115 deletions generators/app/templates/src/app/core/http/cache.interceptor.spec.ts

This file was deleted.

60 changes: 0 additions & 60 deletions generators/app/templates/src/app/core/http/cache.interceptor.ts

This file was deleted.

0 comments on commit 99eea62

Please sign in to comment.