Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngx update detect app as add-on #226

Closed
dvaJi opened this issue Jan 23, 2018 · 2 comments
Closed

Ngx update detect app as add-on #226

dvaJi opened this issue Jan 23, 2018 · 2 comments

Comments

@dvaJi
Copy link
Contributor

dvaJi commented Jan 23, 2018

I'm submitting a...

[X] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

When I try to update my app with ngx update i got:

Make sure you don't have uncommitted changes before overwriting files!
? What's the add-on description? (An awesome ngX-Rocket add-on)

Expected behavior

Should update my application as app and not as add-on

Minimal reproduction of the problem with instructions

From generator-ngx-rocket 3.1.1 to 3.2.0

Environment

- generator version: 3.2.0
- node version: 8.6.0
- npm version: 5.3.0
- OS:  Windows 10

Others:

@sinedied
Copy link
Member

That's definitely not normal, I'll take a look.
Could you post the content of your .yo-rc file?

@dvaJi
Copy link
Contributor Author

dvaJi commented Jan 23, 2018

Sure:
{ "generator-ngx-rocket": { "version": "3.1.1", "props": { "target": [ "web" ], "pwa": true, "ui": "bootstrap", "auth": true, "appName": "myapp", "projectName": "myapp", "packageManager": "npm", "mobile": [] } } }

Also I tried with yo ngx-rocket and it works perfectly.

@sinedied sinedied moved this from In Progress to Done, Unreleased in ngX-Rocket backlog for all repos Jan 24, 2018
sinedied added a commit that referenced this issue Jan 24, 2018
Fixed project type detection (fixes #226)
@sinedied sinedied moved this from Done, Unreleased to Released in ngX-Rocket backlog for all repos Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ngX-Rocket backlog for all repos
  
Released/Processed
Development

No branches or pull requests

2 participants