Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning on build #27

Closed
sinedied opened this issue Feb 15, 2017 · 0 comments
Closed

Warning on build #27

sinedied opened this issue Feb 15, 2017 · 0 comments
Labels
bug
Projects
ngX-Rocket backlog for all repos
Milestone
1.0

Comments

@sinedied
Copy link
Member

There is currently this warning on build, due to a change in the angular-cli webpack config:

WARNING in ./~/encoding/lib/iconv-loader.js
9:12-34 Critical dependency: the request of a dependency is an expression

This is due to the @biesbjerg/ng2-translate-po-loader package, and we have no means of correction as for now.

The only way would be to move from .po translations files to plan .json files, and would probably be related to #3
@sinedied sinedied added the bug label Feb 15, 2017
@sinedied sinedied added this to the 1.0 milestone Feb 15, 2017
@sinedied sinedied mentioned this issue Feb 21, 2017
Closed
@sinedied sinedied moved this from Backlog to In Progress in ngX-Rocket backlog for all repos Feb 27, 2017
sinedied added a commit that referenced this issue Feb 27, 2017
@sinedied
Merge pull request #35 from angular-starter-kit/feature/i18n-json
a274033 
Updated translation system to use embedded .json files (#3, fix #27)
@sinedied sinedied moved this from In Progress to Done in ngX-Rocket backlog for all repos Feb 27, 2017
sinedied added a commit that referenced this issue Feb 27, 2017
@sinedied
Added missing mock to fix unit tests (#27)
991d352
@sinedied sinedied moved this from Done to Archived in ngX-Rocket backlog for all repos Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
ngX-Rocket backlog for all repos
  
Released/Processed
Milestone
1.0
Development

No branches or pull requests
1 participant
@sinedied