Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract credentials from authentication service #447

Closed
sinedied opened this issue Apr 5, 2019 · 0 comments
Closed

Extract credentials from authentication service #447

sinedied opened this issue Apr 5, 2019 · 0 comments

Comments

@sinedied
Copy link
Member

sinedied commented Apr 5, 2019

The current authentication services/helpers and its potential link with HttpService is a source of confusion that can lead to unintuitive errors like this #436 and #432

I suggest to extract the credentials part in a separate service, so that circular dependencies issues are avoided if anyone adds HttpService in the AuthenticationService and use the credentials in an interceptor, which is to me a basic use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ngX-Rocket backlog for all repos
  
Released/Processed
Development

No branches or pull requests

1 participant