Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations:extract didn't work for .ts files #551

Closed
1 of 3 tasks
Achraf-vermeg opened this issue Apr 17, 2020 · 2 comments
Closed
1 of 3 tasks

translations:extract didn't work for .ts files #551

Achraf-vermeg opened this issue Apr 17, 2020 · 2 comments

Comments

@Achraf-vermeg
Copy link

Achraf-vermeg commented Apr 17, 2020

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

npm run translations:extract

didn't extract strings between extract('Hello') from ts files

Expected behavior

Should have string Hello in src\translations\template.json

Minimal reproduction of the problem with instructions

Add extract('Hello') in any ts file (component, module,...)

npm run translations:extract

Environment

ngx-rocket@8.0.1
@sinedied sinedied added the bug label Apr 24, 2020
@sinedied
Copy link
Member

It seems that https://github.com/biesbjerg/ngx-translate-extract has changed the way markers work, you now have to import a specific function from their package 😞

sinedied pushed a commit that referenced this issue Sep 10, 2020
# [9.0.0](8.1.1...9.0.0) (2020-09-10)

### Bug Fixes

* bump min node version to 12 ([5145294](5145294))
* double prompt issue (close [#566](#566)) ([330b174](330b174))
* downgrade stylelint due to pending bugs ([5faf55a](5faf55a))
* incorrect version of @types/jest ([889b147](889b147))
* migrate tests using async to waitForAsync ([b386534](b386534))
* remove unused modules (close [#560](#560)) ([840c033](840c033))
* translation strings extraction (close [#551](#551)) ([cc58749](cc58749))

### Features

* **deps:** update packages ([05e240a](05e240a))
* upgrade to Angular 10 ([#568](#568)) ([ce64a85](ce64a85))

### BREAKING CHANGES

* Now requires Node >= 12 dues to dependencies update.
@sinedied
Copy link
Member

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants