New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Angular 10 #568
Conversation
i published the hmr fixes as 3.0.0 |
Thx PatrickJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR! 👍
Looks good to me, except for my comment on polyfill could you take a look?
BTW, if you update <preference name="android-minSdkVersion" value="19"/>
to <preference name="android-minSdkVersion" value="22"/>
in __cordova._config.xml it should fix the CI for the mobile builds.
Change made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for my comment on polyfill could you take a look?
I made a comment... maybe restore the condition and add to it the material UI also?
let me know...
Cordially
Fabio
Thanks! Expect a new release with your changes soon 🎉 |
# [9.0.0](8.1.1...9.0.0) (2020-09-10) ### Bug Fixes * bump min node version to 12 ([5145294](5145294)) * double prompt issue (close [#566](#566)) ([330b174](330b174)) * downgrade stylelint due to pending bugs ([5faf55a](5faf55a)) * incorrect version of @types/jest ([889b147](889b147)) * migrate tests using async to waitForAsync ([b386534](b386534)) * remove unused modules (close [#560](#560)) ([840c033](840c033)) * translation strings extraction (close [#551](#551)) ([cc58749](cc58749)) ### Features * **deps:** update packages ([05e240a](05e240a)) * upgrade to Angular 10 ([#568](#568)) ([ce64a85](ce64a85)) ### BREAKING CHANGES * Now requires Node >= 12 dues to dependencies update.
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi,
With this PR the Angular dependency and file structure will be updated to latest (ATM of writing) to latest versions.
I reproduce the structure for the new json introduced in version 10, I mean tsconfig.base.json.
Still a warning (not due to this PR) with angular-hmr... it cause with the version 2.1.3
the common warning
I made a PR to "solve" this warning with latest angular version PatrickJS/angular-hmr#87
Tested with Angular + Material and Bootstrap as UI
Hope it help
Cordially
Fabio