New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.editorconfig missing quote_type = single
for formatting of typescript files
#580
Comments
This may be an issue with the prettier VS Code extension or your config, as in the generated project there's already a setting in It would be ok to enforce the I also tried with a freshly generated project where I enabled the "prettier" option and the formatting is fine, using the settings from Are you sure you enabled the "prettier" option when generating your project, and you're using this extension for formatting? |
I just saw that |
# [9.2.0](9.1.0...9.2.0) (2021-01-14) ### Bug Fixes * app not loading with Electron v11 ([1444bf0](1444bf0)) * incorrect hads version ([ba20ff1](ba20ff1)) * rename env script to fix execution in some environments (closes [#575](#575)) ([ec93fdb](ec93fdb)) * update electron templates ([3433465](3433465)) * update generator dependencies ([bda29d9](bda29d9)) * update jest config ([4b4a357](4b4a357)) * update packages and fix peer dependencies ([64098dc](64098dc)) * update RouteReusableStrategy for Angular 11 ([#576](#576)) ([3077f5b](3077f5b)) ### Features * add brazilian portuguese language ([1a6d728](1a6d728)) * enable webpack 5 ([8592a71](8592a71)) * migrate to @ngneat/until-destroy (fix [#577](#577)) ([3a77fcb](3a77fcb)) * update editorconfig (fixes [#580](#580)) ([9f036b3](9f036b3))
🎉 This issue has been resolved in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm submitting a...
Current behavior
Using prettier as formatter in VSCode, format whole .ts typescript file makes all single-quote (') as double quotes (")
Expected behavior
Expected is that when organizing imports and formatting document all quotes should be single
Minimal reproduction of the problem with instructions
Environment
Others:
ℹ️ WORKAROUND
.editorconfig
withI think as a fix, this manual change to
.editorconfig
should be included in the boilerplate/generated code by ngx since in previous versions single quote is used by default (I think by prettier in package.json)(that's what I get used, unless this changed). So this might be a regression issue.The text was updated successfully, but these errors were encountered: