Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic: update to rc1 and fix tabs router and selected tab #428

Conversation

captaincaius
Copy link
Contributor

tabs finally work nicely in standalone mode with normal angular router and proper lazy loading \o/

minor changes:

  • ionic tabs shell component more lazy-loading-friendly
  • app component unit test fix (platform no longer mocked b/c ionic's internals depend on the real thing)
  • angular dependencies raised to match ionic's (no real difference cause we're using caret anyway)
  • ionicons added to output in test so tests don't show 404s
  • build-angular dependency increased so npm audit doesn't cry

@sinedied
Copy link
Member

Except for my question, looks good to me good work 👍

BTW it seems they resolved ionic-team/ionic-framework#15956, when the rc2 is out we should be able to remove my workaround

@captaincaius
Copy link
Contributor Author

Except for my question, looks good to me good work

BTW it seems they resolved ionic-team/ionic#15956, when the rc2 is out we should be able to remove my workaround

thanks :)

ok... we're gonna merge this first though right?

Copy link
Member

@sinedied sinedied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course let's merge this, the cleanup will come after

@sinedied sinedied merged commit 2befb22 into ngx-rocket:release/6.0.x Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants