Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The params for translations are ignored #929

Open
esavelyeva opened this issue Sep 27, 2018 · 1 comment
Open

The params for translations are ignored #929

esavelyeva opened this issue Sep 27, 2018 · 1 comment

Comments

@esavelyeva
Copy link

Current behavior

The params for translations are ignored.

Expected behavior

Params values should be added into the translation.

How do you think that we should fix this?

No idea.

Minimal reproduction of the problem with instructions

Forked ngx-translate demo from GitHub readme to reproduce https://stackblitz.com/edit/github-a35qvr

Environment

ngx-translate version: 10.0.1
Angular version: 6.0.0

Browser:
any

@esavelyeva
Copy link
Author

For now I'm using this function to apply the prams to the translations:

export function applyParamsToTranslation(trans: string, params: Object): string {
  // TODO add err handling
  function getTransParamNames(text: string): Array<string> {
    return text.match(/{{\s*[\w\.]+\s*}}/g).map(function(bracedParam) {
      return bracedParam.match(/[\w\.]+/)[0];
    });
  }
  const keys = getTransParamNames(trans);
  for (let i = 0; i < keys.length; i++) {
    if (params[keys[i]]) {
      trans = trans.replace(keys[i], params[keys[i]]);
    }
  }
  return trans.replace(/{{|}}/g, '');
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant