Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

Fix loading of translations when base-href is set #12

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

joachimprinzbach
Copy link
Contributor

Closes #11

@ocombe
Copy link
Collaborator

ocombe commented Jul 7, 2017

Doesn't it cause trouble when you use the router in html5 mode?
Let's say that you navigate to http://localhost/route1, then it will try to load from http://localhost/route1/assets/i18n/ and fail

@joachimprinzbach
Copy link
Contributor Author

For me it works fine, even with the router in html5 mode.

@ocombe
Copy link
Collaborator

ocombe commented Jul 7, 2017

did you try to reload your app from one of those paths? if it loaded the translations when you were at the root, of course it should still work when you navigate

@joachimprinzbach
Copy link
Contributor Author

Yeah I tried it - it does work ;-)

@joachimprinzbach
Copy link
Contributor Author

Have a look at this repo (branch http-loader)
https://github.com/joachimprinzbach/cli-project/tree/http-loader
You can reload the app from every path (either "home" or "profile") - language files get fetched correctly.

@ocombe ocombe merged commit c801802 into ngx-translate:master Sep 13, 2017
@ocombe
Copy link
Collaborator

ocombe commented Sep 13, 2017

Sorry but I had to revert because it fails the tests, can you make them pass and then I'll merge it.

@buehler
Copy link

buehler commented Oct 2, 2018

This is a heavy issue

@buehler
Copy link

buehler commented Oct 2, 2018

Still "broken" :-) just ran into the problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants