Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

support for http headers #19

Closed
wants to merge 1 commit into from
Closed

support for http headers #19

wants to merge 1 commit into from

Conversation

martinduris
Copy link

After this pull request we can use:

TranslateHttpBasicAuthLoader(http, new HttpHeaders().set('Authorization', 'Basic ' + btoa(conf.username + ':' + conf.password)), environment.base_path + '/i18n/', '.json');

@martinduris martinduris mentioned this pull request Aug 1, 2017
@woteska woteska mentioned this pull request Jan 6, 2018
@ocombe
Copy link
Collaborator

ocombe commented Jan 6, 2018

Hello, thanks for the PR but I prefer to keep this loader minimal. If anyone wants this functionality, it's super simple to copy your code and use this instead, that's why I made the library modular, there will always be someone who needs a new thing on their loader.

@ocombe ocombe closed this Jan 6, 2018
@martinduris
Copy link
Author

@ocombe hi, i understood - thanks for reply !

@woteska
Copy link

woteska commented Jan 6, 2018

I also understood, but I don't understand, where don't you have to set headers for a http request. :) So I think it should be in basic implements, but of course, I can make a little workaround... just it is not logical.

Thank you for all of that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants