Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): added support of angular 6 #11

Merged
merged 2 commits into from
Nov 26, 2018
Merged

feat(core): added support of angular 6 #11

merged 2 commits into from
Nov 26, 2018

Conversation

NarHakobyan
Copy link
Contributor

Added support for angular 6, test failure reason was version of @types/jasmine

@JanMalch
Copy link
Collaborator

JanMalch commented Nov 26, 2018

What's the usual (CI) procedure for testing support of dependency versions? I mean I can't just lower the version number without confirming that it works with both ng6 and ng7 in the integration test?

Moved question to #10

@JanMalch JanMalch merged commit 77d38ce into ngxs-labs:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants