router-plugin: RouterNavigation should be fired only when NavigationEnd is triggered

[xmlking]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior

RouterNavigation event is fired every time a navigation is initiated. some times navigation action will be canceled due to AuthGuards.

    this.actions$
      .pipe(
        ofActionSuccessful(RouterNavigation),
        map((action: RouterNavigation) => action.routerState as any)
      )
      .subscribe(data => {
        console.log(data.breadcrumbs);
        this.pageTitle.setTitle(data.breadcrumbs);
        this.analytics.setPage(data.url);
      });

Expected behavior

we don't want to update title if Router event canceled. would be nice if you can configure router-plugin module only fire RouterNavigation when NavigationEnd event is fired. or expose more events e.g., RouterNavigationSuccess etc.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Libs:
- @angular/core version: 7.0.3
- @ngxs/store version: 3.2.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: v11.1.0
- Platform:  Mac

Others:

[xmlking]

may be this can be updated to fire RouterNavigationSuccess action
https://github.com/ngxs/store/blob/master/packages/router-plugin/src/router.state.ts#L93

  private setUpStateRollbackEvents(): void {
    this._router.events.subscribe(e => {
      if (e instanceof RoutesRecognized) {
        this.lastRoutesRecognized = e;
      } else if (e instanceof NavigationEnd) {
        this.dispatchRouterSuccess(e);
      } else if (e instanceof NavigationCancel) {
        this.dispatchRouterCancel(e);
      } else if (e instanceof NavigationError) {
        this.dispatchRouterError(e);
      }
    });
  }

[markwhitfeld]

@xmlking This issue may have been fixed by PR #895 which has just been released in v3.4.3!
Could you test and confirm if this issue has been fixed or not?

[xmlking]

👍 working as expected