Memoize inner selector function #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2018 23:12
Also change to a single value cache for performance The deep cache isn't used anyway
amcdnl
reviewed
Jun 2, 2018
| return false; | ||
| } | ||
|
|
||
| // Do this in a for loop (and not a `forEach` or an `every`) so we can determine equality as fast as possible. |
There was a problem hiding this comment.
I thought you could break out of a forEach by returning false. Just a side note.
There was a problem hiding this comment.
This is the code from the reselect redux library, so I assume it was done this way for fine tuned performance
There was a problem hiding this comment.
Ya, while used to be fastest but I think thats changed recently. https://jsperf.com/for-vs-foreach/333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.