Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whenDocumentVisible is not exported from ngxtension/when-document-visible entry point #424

Open
FabienDehopre opened this issue Jun 17, 2024 · 1 comment · May be fixed by #425
Open

whenDocumentVisible is not exported from ngxtension/when-document-visible entry point #424

FabienDehopre opened this issue Jun 17, 2024 · 1 comment · May be fixed by #425

Comments

@FabienDehopre
Copy link
Contributor

FabienDehopre commented Jun 17, 2024 •
edited
Loading

I forgot to export the whenDocumentVisible operator from the entry point. :(
I'll provide a PR as soon as possible.
@FabienDehopre FabienDehopre linked a pull request Jun 17, 2024 that will close this issue
Open
@FabienDehopre
Copy link
Contributor Author

@nartc or @eneajaho Sorry to bother you but this bug is important because the RxJS whenDocumentVisible operator is not exported from the entrypoint ngxtension/when-document-visible which makes it impossible to use.
I know it's my fault because I forgot to check the index.ts file before subimiting the initial implementation.
However, the PR that fixes the bug is ready since last week.
I would really appreciate if one of you (or any other code owner) can review the PR.
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@FabienDehopre