Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(when-document-visible): export the whenDocumentVisible operator… #425

Merged
merged 3 commits into from
Jun 29, 2024

Conversation

FabienDehopre
Copy link
Contributor

… from the ngxtension/when-document-visible entry point

fixes #424

@FabienDehopre
Copy link
Contributor Author

@nartc Any idea why the CI fails? I saw that it complains about missing lock file.
However, the file pnpm-lock.yaml seems to be present.

@FabienDehopre
Copy link
Contributor Author

@nartc I've found why the build keeps failing (at least for me)... the CI pipeline requested to install pnpm v8 when the lockfile version was for pnpm v9 (as requested by the packageManager field in package.json).
I've update the ci.yml file to not request a specific version of pnpm. So it will install the one requested by packageManager in package.json

@FabienDehopre
Copy link
Contributor Author

@all-contributors please add @FabienDehopre for code

Copy link
Contributor

@FabienDehopre

@FabienDehopre already contributed before to code

@eneajaho eneajaho merged commit 5bd7800 into ngxtension:main Jun 29, 2024
1 check failed
@eneajaho
Copy link
Collaborator

Thanks @FabienDehopre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

whenDocumentVisible is not exported from ngxtension/when-document-visible entry point
2 participants