Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map-array): make it work with either writable or readonly source arrays #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diegovilar
Copy link
Contributor

This PR fixes #274

Copy link

nx-cloud bot commented Feb 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6159c54. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@eneajaho
Copy link
Collaborator

Hello @diegovilar
Can you also write a test for this? So, we can make sure we don't break anyone?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapArray is typed in a way that doesn't work with readonly source arrays
2 participants