feat: add rxjs operators poll and whenDocumentVisible
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR not found |
|
What do you mean? |
nartc
approved these changes
Jun 10, 2024
|
@all-contributors please add @FabienDehopre for code |
ajitzero
reviewed
Jun 10, 2024
ajitzero
reviewed
Jun 10, 2024
ajitzero
approved these changes
Jun 10, 2024
|
@all-contributors please add @FabienDehopre for code |
|
@FabienDehopre looks like the test failed. Can you take a look? |
|
@all-contributors please add @FabienDehopre for code (third time the charm?) |
|
I've put up a pull request to add @FabienDehopre! 🎉 |
|
@all-contributors please add @FabienDehopre for code (fourth time 🥲) |
|
@FabienDehopre already contributed before to code |
|
I've fixed the failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two RxJs operators that works well together but still can be used independently.
pollcan be used to poll an API at a fixed interval with an optional initial delay.whenDocumentVisibleis the RxJs counterpart of theinjectDocumentVisibilityand can be used to pause and resume a RxJs stream based on the document visibility state.Related to #405