Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

YouTube extraction not working. #24

Merged
merged 2 commits into from
May 30, 2020
Merged

Conversation

KaustubhPatange
Copy link
Contributor

So I encounter an issue where adaptive & muxed streams are returning null url parameter. All other parameter were working fine.

Source:
It seems like there was a problem while parsing JSON since mainly YouTube has changed their notation for cipher object as signatureCipher. This only difference was causing YTMedia returning null url.

Fix:
I am submitting a PR that fixes this issue. I've tested it myself and it had fix the issue (extraction is working again). Consider merging this request. :)

@ahmcode
Copy link

ahmcode commented May 30, 2020

So I encounter an issue where adaptive & muxed streams are returning null url parameter. All other parameter were working fine.

Source:
It seems like there was a problem while parsing JSON since mainly YouTube has changed their notation for cipher object as signatureCipher. This only difference was causing YTMedia returning null url.

Fix:
I am submitting a PR that fixes this issue. I've tested it myself and it had fix the issue (extraction is working again). Consider merging this request. :)

Thanks! It's working.

@Dolanpls
Copy link

It works perfect! Thanks!

@nhCoder nhCoder merged commit 74127fe into nhCoder:master May 30, 2020
@FelipeRRM
Copy link

Works great with this fix, thanks! But you forgot to replace usages of getCipher to getSignatureCipher, code doesn't build without this.

@KaustubhPatange
Copy link
Contributor Author

KaustubhPatange commented May 30, 2020

@FelipeRRM Yeah that might be! As Android Studio refactoring doesn't tell you which files have changed unless VCS is enabled. Also, this repository project cannot be compiled in Android studio due to unsupported gradle version so I have to update files manually which caused this silly human error.

You can submit a PR to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants