Allow Scenes to provide their own ViewController instances. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhaarman
force-pushed
the
scene-as-controllerfactory
branch
2 times, most recently
from
eb9f74b
to
4ccd3fa
Compare
nhaarman
commented
Nov 24, 2018
ext/acorn-android/src/main/java/com/nhaarman/acorn/android/presentation/ViewProvidingScene.kt
Show resolved
Hide resolved
...acorn-android/src/main/java/com/nhaarman/acorn/android/presentation/ViewControllerFactory.kt
Show resolved
Hide resolved
...acorn-android/src/main/java/com/nhaarman/acorn/android/presentation/ViewControllerFactory.kt
Show resolved
Hide resolved
...c/main/java/com/nhaarman/acorn/android/presentation/internal/BindingViewControllerFactory.kt
Outdated
Show resolved
Hide resolved
nhaarman
commented
Nov 25, 2018
...droidTest/java/com/nhaarman/acorn/android/presentation/InflatingViewControllerFactoryTest.kt
Show resolved
Hide resolved
nhaarman
commented
Nov 25, 2018
ext/acorn-android/src/main/java/com/nhaarman/acorn/android/presentation/ViewProvidingScene.kt
Show resolved
Hide resolved
To get started easier, Scenes will be able to create their own ViewController instances, much like Fragment's onCreateView.
nhaarman
force-pushed
the
scene-as-controllerfactory
branch
from
4ccd3fa
to
773fb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get started easier, Scenes will be able to
create their own ViewController instances, much like
Fragment's onCreateView.
From a purists' point of view, this is unwanted: the Scene will have a direct dependency on the Container implementation. However, for trivial cases being able to provide a ViewController directly greatly reduces boilerplate, and keeps related code together.
Scenes providing ViewControllers can be used together with the decoupled ViewControllerFactory way of providing ViewControllers; the Scene has precedence.