make sure otel.Handle is called only if err != nil #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nhatthm your feedback is appreciated :) |
auvn
force-pushed
the
error-handler-update
branch
2 times, most recently
from
98ddd8f
to
4de7f3a
Compare
auvn
force-pushed
the
error-handler-update
branch
from
4de7f3a
to
7a068fe
Compare
nhatthm
reviewed
May 20, 2023
Hey, thanks for the PR. I left only a small comment on the naming. |
auvn
force-pushed
the
error-handler-update
branch
2 times, most recently
from
a584ef4
to
ae35d98
Compare
auvn
force-pushed
the
error-handler-update
branch
from
ac2b6d4
to
34988c5
Compare
nhatthm
approved these changes
May 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 22 +1
Lines 1208 1212 +4
=========================================
+ Hits 1208 1212 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run my application with otelsql for a sql storage. I have the following in my logs:
2023/05/19 11:58:25
2023/05/19 11:58:25
2023/05/19 11:58:25
2023/05/19 11:58:25
2023/05/19 11:58:25
2023/05/19 11:58:25
2023/05/19 11:58:25
Otelsql uses otel.Handle function regardless of error value.
I suppose nil errors shouldn't go to logs at all.
I'm suggesting this PR in order to handle nil errors silently.