Skip to content
This repository has been archived by the owner on Aug 29, 2022. It is now read-only.

Test AlecAivazis/survey/pull/335 #1

Closed
wants to merge 2 commits into from
Closed

Test AlecAivazis/survey/pull/335 #1

wants to merge 2 commits into from

Conversation

nhatthm
Copy link
Owner

@nhatthm nhatthm commented Apr 20, 2021

This PR is for testing the solution in AlecAivazis/survey#335

The scenario

    Scenario: Multiple Password prompts
        Given I see a password prompt "Enter username:", I answer "user@example.org"
        And I see a password prompt "Enter password:", I answer "123456"

        Then ask for password "Enter username:", receive "user@example.org"
        And ask for password "Enter password:", receive "123456"

        And console output is:
        """
        ? Enter username: ****************
        ? Enter password: ******
        """

It failed (https://github.com/nhatthm/surveydog/runs/2388484313#step:5:110) because the cursor is not moved back to the beginning of the line

  Scenario: Multiple Password prompts # ../password.feature:19
    And console output is: # ../password.feature:26
      Error: 
	Error Trace:	assertions.go:44
	            				manager.go:127
	            				value.go:476
	            				value.go:337
	            				stepdef.go:159
	            				suite.go:138
	            				suite.go:225
	            				suite.go:284
	            				run.go:111
	            				asm_amd64.s:1374
	Error:      	Not equal: 
	            	expected: "? Enter username: ****************\n? Enter password: ******"
	            	actual  : "? Enter username: ****************\n                  ? Enter password: ******"
	            	
	            	Diff:
	            	--- Expected
	            	+++ Actual
	            	@@ -1,2 +1,2 @@
	            	 ? Enter username: ****************
	            	-? Enter password: ******
	            	+                  ? Enter password: ******

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1 (1f52358) into master (6bb0371) will decrease coverage by 4.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   94.84%   90.72%   -4.13%     
==========================================
  Files           2        2              
  Lines          97       97              
==========================================
- Hits           92       88       -4     
- Misses          3        8       +5     
+ Partials        2        1       -1     
Flag Coverage Δ
featuretests-Linux 89.69% <ø> (-2.07%) ⬇️
featuretests-macOS 89.69% <ø> (-2.07%) ⬇️
unittests-Linux 53.60% <ø> (ø)
unittests-macOS 53.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager.go 91.30% <0.00%> (-5.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb0371...1f52358. Read the comment docs.

@nhatthm
Copy link
Owner Author

nhatthm commented Apr 20, 2021

The tests passed in https://github.com/nhatthm/surveydog/actions/runs/766390576 after applying the fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant