New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substitution estimator should use counterfactuals #5

Closed

nhejazi opened this issue Nov 27, 2018 · 1 comment

Assignees

Labels

bug

Owner

nhejazi commented Nov 27, 2018

In https://github.com/nhejazi/medshift/blob/master/R/est_sub.R#L36-L44, the substitution estimator uses predicted values for the sub-groups A = 1 and A = 0, it should use counterfactual values similar to how Dzw is computed for the efficient estimator

nhejazi self-assigned this

nhejazi added the bug label

nhejazi added a commit that referenced this issue


          resolve #5 by abstraction

a623a6d

Owner Author

nhejazi commented Nov 29, 2018 •

edited

Resolved in #9 by use of the new compute_Dzw function

nhejazi closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment