Relationship pairing fixes (matching one-to-many relationship ends and foreign key column naming) #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pairing should check property types correspondence to avoid pair collection with reference property if their types does not match.
…ypes correspondence to avoid pair wrong properties.
…two ends will use the same (single) foreign column name at children table. Before that fix such relations were mapped this way: "one" side used childtype.Name+"_id", "many" side used referenceToParentProperty.Name+"_id". It seemed to work just because usually referenceToParent property name is equal to parent's type name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 problems fixed:
It was based on alphabetical order of the propertiess.
Even if 2 end of the relation are properly detected there were created 2 foreign key columns on the many side. It worked properly only when reference property from child to parent was named: [parentTypeName].
PS: I just found that 1. problem is fixed by #313 ...
Fortunately fix is the same as proposed here.