Prevent calling UpdateTimesStampsCache for non cached entites

[gokhanabatay]

When query cache enabled, I realized that we are storing updatetimestampscache for non cached entities.
Is this really necessary in our scenario we use query cache for just Cache.ReadWrite or Cache.Readonly or Cache.NonstrictReadWrite entities, not non cached entities.

We need high performance to do that we need to decrease Sync. and locking for dml/select operations, its locks all threads in same application its too much cost for per operation.

I think that this needs to be configurable(Store all entities updatetimestampscache or just cacheable entities) or we give us a way to implement our UpdateTimestampsCache, because its readonly?

Action Queue can be check? executable.PropertySpaces && execuatble.Persister.Cache != null

                 private void RegisterCleanupActions(IExecutable executable)
		{
			if (executable is IAsyncExecutable asyncExecutable)
			{
				RegisterProcess(asyncExecutable.BeforeTransactionCompletionProcess);
				RegisterProcess(asyncExecutable.AfterTransactionCompletionProcess);
			}
			else
			{
#pragma warning disable 618,619
				RegisterProcess(executable.BeforeTransactionCompletionProcess);
				RegisterProcess(executable.AfterTransactionCompletionProcess);
#pragma warning restore 618,619
			}
			if (executable.PropertySpaces != null)
			{
				executedSpaces.UnionWith(executable.PropertySpaces);
			}
		}

[gokhanabatay]

Thank you quick reply @hazzik but i think this is not Trivial issue, because when second level cache enabled there is huge performance fall down test could show this.

Summary;
ReadWriteCache has lock problems and slower than database if we did not use "in memory" second level cache.
Please take a consideration early release of (#2115 #2129) thank you.

Oracle Exa Data Database 500 Thread Api Call

2 db read(very little tables), 1 Cache read(Read-Write Cache), 1 insert

1. Second level cache disabled, query cache disabled
   

2. Second level cache enabled with master code
   

3. Second level cache enabled with your fixes including Statefull Session commit performance issue when nothing changed and second level cache with query cache enabled #2115 Prevent calling UpdateTimesStampsCache for non cached entites #2129
   

---

2 db read(very little tables), 1 Cache read(Nonstrick Read-Write Cache), 1 insert

1. Second level cache enabled with master code
   

2. Second level cache enabled with your fixes including Statefull Session commit performance issue when nothing changed and second level cache with query cache enabled #2115 Prevent calling UpdateTimesStampsCache for non cached entites #2129
   

[maca88]

ReadWriteCache has lock problems and slower than database if we did not use "in memory" second level cache.

#2147 should fix that.

[gokhanabatay]

@hazzik , @maca88 hi issue still exists when do you plan to merge and make a release.

[gokhanabatay]

#2744 #2742 merge of pull request, there will be no need custom UpdateTimestampsCache.