Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade dependency System.Data.SQLite.Core 1.0.118 -> 1.0.117 #3413

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Downgrade dependency System.Data.SQLite.Core 1.0.118 -> 1.0.117 #3413

merged 4 commits into from
Aug 21, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 16, 2023 •
edited

To fix intermittent test failure introduced in #3098:

1) Error : NHibernate.Test.NHSpecificTest.GH2710.Fixture.Test
System.AggregateException : One or more errors occurred. (could not execute update query[SQL: update Entity set MrcDailyMoved=? where mbrid = :Filter.MbrId and (Id in (? , ? , ? , ? , ? , ? , ? , ? , ? , ?))]) (could not execute update query[SQL: update Entity set MrcDailyMoved=? where mbrid = :Filter.MbrId and (Id in (? , ? , ? , ? , ? , ? , ? , ? , ? , ?))])
  ----> NHibernate.Exceptions.GenericADOException : could not execute update query[SQL: update Entity set MrcDailyMoved=? where mbrid = :Filter.MbrId and (Id in (? , ? , ? , ? , ? , ? , ? , ? , ? , ?))]
  ----> NHibernate.Exceptions.GenericADOException : could not execute update query[SQL: update Entity set MrcDailyMoved=? where mbrid = :Filter.MbrId and (Id in (? , ? , ? , ? , ? , ? , ? , ? , ? , ?))]
  ----> System.Data.SQLite.SQLiteException : database is locked
database is locked
Data:
  actual-sql-query: update Entity set MrcDailyMoved=@p0 where mbrid = @p1 and (Id in (@p2 , @p3 , @p4 , @p5 , @p6 , @p7 , @p8 , @p9 , @p10 , @p11))
  ----> System.Data.SQLite.SQLiteException : database is locked
database is locked
Data:
  actual-sql-query: update Entity set MrcDailyMoved=@p0 where mbrid = @p1 and (Id in (@p2 , @p3 , @p4 , @p5 , @p6 , @p7 , @p8 , @p9 , @p10 , @p11))
   at System.Threading.Tasks.TaskReplicator.Run[TState](ReplicatableUserAction`1 action, ParallelOptions options, Boolean stopOnFirstFailure)
   at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Parallel.ThrowSingleCancellationExceptionOrOtherException(ICollection exceptions, CancellationToken cancelToken, Exception otherException)
   at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
   at System.Threading.Tasks.Parallel.For(Int32 fromInclusive, Int32 toExclusive, Action`1 body)
   at NHibernate.Test.NHSpecificTest.GH2710.Fixture.Test() in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate.Test/NHSpecificTest/GH2710/Fixture.cs:line 40
--GenericADOException
   at NHibernate.Hql.Ast.ANTLR.Exec.BasicExecutor.Execute(QueryParameters parameters, ISessionImplementor session) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Hql/Ast/ANTLR/Exec/BasicExecutor.cs:line 95
   at NHibernate.Engine.Query.HQLQueryPlan.PerformExecuteUpdate(QueryParameters queryParameters, ISessionImplementor session) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Engine/Query/HQLQueryPlan.cs:line 194
   at NHibernate.Impl.SessionImpl.ExecuteUpdate(IQueryExpression queryExpression, QueryParameters queryParameters) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Impl/SessionImpl.cs:line 2357
   at NHibernate.Impl.AbstractQueryImpl2.ExecuteUpdate() in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Impl/AbstractQueryImpl2.cs:line 42
   at NHibernate.Linq.DmlExtensionMethods.Update[TSource](IQueryable`1 source, Expression`1 expression) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Linq/DmlExtensionMethods.cs:line 36
   at NHibernate.Test.NHSpecificTest.GH2710.Fixture.UpdateEntity(List`1 ids) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate.Test/NHSpecificTest/GH2710/Fixture.cs:line 52
   at NHibernate.Test.NHSpecificTest.GH2710.Fixture.<>c__DisplayClass2_0.<Test>b__0(Int32 i) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate.Test/NHSpecificTest/GH2710/Fixture.cs:line 42
   at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`1.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`1.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
   at System.Threading.Tasks.TaskReplicator.Replica.Execute()
--GenericADOException
   at NHibernate.Hql.Ast.ANTLR.Exec.BasicExecutor.Execute(QueryParameters parameters, ISessionImplementor session) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Hql/Ast/ANTLR/Exec/BasicExecutor.cs:line 95
   at NHibernate.Engine.Query.HQLQueryPlan.PerformExecuteUpdate(QueryParameters queryParameters, ISessionImplementor session) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Engine/Query/HQLQueryPlan.cs:line 194
   at NHibernate.Impl.SessionImpl.ExecuteUpdate(IQueryExpression queryExpression, QueryParameters queryParameters) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Impl/SessionImpl.cs:line 2357
   at NHibernate.Impl.AbstractQueryImpl2.ExecuteUpdate() in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Impl/AbstractQueryImpl2.cs:line 42
   at NHibernate.Linq.DmlExtensionMethods.Update[TSource](IQueryable`1 source, Expression`1 expression) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Linq/DmlExtensionMethods.cs:line 36
   at NHibernate.Test.NHSpecificTest.GH2710.Fixture.UpdateEntity(List`1 ids) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate.Test/NHSpecificTest/GH2710/Fixture.cs:line 52
   at NHibernate.Test.NHSpecificTest.GH2710.Fixture.<>c__DisplayClass2_0.<Test>b__0(Int32 i) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate.Test/NHSpecificTest/GH2710/Fixture.cs:line 42
   at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`1.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`1.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
   at System.Threading.Tasks.TaskReplicator.Replica.Execute()
--SQLiteException
   at System.Data.SQLite.SQLite3.Prepare(SQLiteConnection cnn, SQLiteCommand command, String strSql, SQLiteStatement previous, UInt32 timeoutMS, String& strRemain)
   at System.Data.SQLite.SQLiteCommand.BuildNextCommand()
   at System.Data.SQLite.SQLiteDataReader.NextResult()
   at System.Data.SQLite.SQLiteDataReader..ctor(SQLiteCommand cmd, CommandBehavior behave)
   at System.Data.SQLite.SQLiteCommand.ExecuteReader(CommandBehavior behavior)
   at System.Data.SQLite.SQLiteCommand.ExecuteNonQuery(CommandBehavior behavior)
   at NHibernate.AdoNet.AbstractBatcher.ExecuteNonQuery(DbCommand cmd) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/AdoNet/AbstractBatcher.cs:line 234
   at NHibernate.Hql.Ast.ANTLR.Exec.BasicExecutor.Execute(QueryParameters parameters, ISessionImplementor session) in /home/runner/work/nhibernate-core/nhibernate-core/src/NHibernate/Hql/Ast/ANTLR/Exec/BasicExecutor.cs:line 83
--SQLiteException
   at System.Data.SQLite.SQLite3.Prepare(SQLiteConnection cnn, SQLiteCommand command, String strSql, SQLiteStatement previous, UInt32 timeoutMS, String& strRemain)
   at System.Data.SQLite.SQLiteCommand.BuildNextCommand()
   at System.Data.SQLite.SQLiteDataReader.NextResult()
   at System.Data.SQLite.SQLiteDataReader..ctor(SQLiteCommand cmd, CommandBehavior behave)
   at System.Data.SQLite.SQLiteCommand.ExecuteReader(CommandBehavior behavior)
   at System.Data.SQLite.SQLiteCommand.ExecuteNonQuery(CommandBehavior behavior)

@hazzik
Copy link
Member

hazzik commented Aug 16, 2023

Can we downgrade to 1.117.x? The changes that are relevant to the locking of the DB is in 118.

@bahusoid
Copy link
Member Author

bahusoid commented Aug 17, 2023 •
edited

Can we downgrade to 1.117.x? The changes that are relevant to the locking of the DB is in 118.

Ok. If you are sure. I didn't check when it got broken.

@bahusoid bahusoid changed the title Revert dependency System.Data.SQLite.Core 1.0.118 -> 1.0.115.5 Revert dependency update System.Data.SQLite.Core 1.0.118 -> 1.0.117 Aug 17, 2023
@bahusoid bahusoid changed the title Revert dependency update System.Data.SQLite.Core 1.0.118 -> 1.0.117 Downgrade dependency System.Data.SQLite.Core 1.0.118 -> 1.0.117 Aug 17, 2023
@fredericDelaporte fredericDelaporte added this to the 5.5 milestone Aug 17, 2023
@hazzik hazzik enabled auto-merge (squash) August 21, 2023 00:38
@hazzik hazzik merged commit 555d340 into nhibernate:master Aug 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: Tests p: Minor r: Fixed t: Bug
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bahusoid @hazzik @fredericDelaporte