Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not append from element when already in from #3476

Merged
merged 3 commits into from Feb 2, 2024
Merged

Do not append from element when already in from #3476

merged 3 commits into from Feb 2, 2024

Conversation

fredericDelaporte
Copy link
Member

Fix #3465.

@fredericDelaporte fredericDelaporte added this to the 5.5.1 milestone Feb 1, 2024
@fredericDelaporte
Copy link
Member Author

@bahusoid, this fixes a regression from #3369. May you have a look?

It does succeed the test cases from #3369, but I have not check all the other tests, I am waiting for the CI builds.

@fredericDelaporte fredericDelaporte changed the base branch from master to 5.5.x February 1, 2024 17:20
@fredericDelaporte fredericDelaporte mentioned this pull request Feb 1, 2024
Closed
@fredericDelaporte fredericDelaporte merged commit 8aae0b7 into nhibernate:5.5.x Feb 2, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

Invalid SQL created for some joins in a subquery
2 participants
@fredericDelaporte @hazzik