Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support an arbitrary length for CultureInfoType #3481

Merged
merged 6 commits into from Feb 6, 2024
Merged

Support an arbitrary length for CultureInfoType #3481

merged 6 commits into from Feb 6, 2024

Conversation

fredericDelaporte
Copy link
Member

fix #3473

@fredericDelaporte fredericDelaporte added this to the next minor milestone Feb 2, 2024
@fredericDelaporte
Add a dedicated test for CultureInfoType
b0046cc 
And refactor the teardown of these tests.
@fredericDelaporte fredericDelaporte enabled auto-merge (squash) February 5, 2024 19:40
@fredericDelaporte
Copy link
Member Author

The DeepSource "failure" is plain wrong: attempting to apply their suggestion can only result in not compiling code. (And classifying as a major issue the use of the old using pattern instead of the newer one is quite an overstatement.)

@fredericDelaporte fredericDelaporte mentioned this pull request Feb 6, 2024
Closed
@fredericDelaporte fredericDelaporte merged commit e65ab36 into nhibernate:master Feb 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

The sql type of the CultureInfoType is too short
2 participants
@fredericDelaporte @hazzik