Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-3247 - Char value gets 'cached' - fix and test cases #575

Merged
merged 1 commit into from Mar 20, 2017
Merged

NH-3247 - Char value gets 'cached' - fix and test cases #575

merged 1 commit into from Mar 20, 2017

Conversation

fredericDelaporte
Copy link
Member

NH-3247 - Char value gets 'cached' - fix and test cases.

@hazzik hazzik self-requested a review March 19, 2017 23:44
@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Mar 20, 2017 •
edited

Unfortunatly my test case is not supported by Oracle with managed32 driver it seems.

Fixture.CharParameterValueShouldNotBeCached
======= Failed test run #1 ==========
OneTimeSetUp: NHibernate.HibernateException : ORA-00904: : invalid identifier
  ----> Oracle.ManagedDataAccess.Client.OracleException : ORA-00904: : invalid identifier

I do not have Oracle knowledge. I may install some free edition if any to try check what happen and whether this test should simply be ignored for Oracle, or need some fixing. (Or is there some place in teamcity to gather more information on the failure?)

@fredericDelaporte
Copy link
Member Author

Forget it, the error code is sufficiently documented, the trouble is I have named a property Initial which is a reserved word for Oracle. Gonna escape it.

@hazzik hazzik merged commit fb7dd79 into nhibernate:master Mar 20, 2017
@fredericDelaporte fredericDelaporte deleted the NH-3247 branch March 20, 2017 10:09
@hazzik hazzik modified the milestone: 5.0.0 Mar 24, 2017
@hazzik hazzik added the r: Fixed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Bug
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredericDelaporte @hazzik