NH-4032 - Multiple factories in thread static context. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
changed the title
fredericDelaporte
force-pushed
the
NH-4032
branch
from
444db38
to
614513e
Compare
This was referenced Jun 13, 2017
fredericDelaporte
force-pushed
the
NH-4032
branch
from
614513e
to
32522e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NH-4032 - Supports multiple factories with ThreadStaticSessionContext
ThreadStaticSessionContextdoes not currently supports multiple factories usage in a same context (thread in its case).Supporting it should just be a mater of deriving from
MapBasedSessionContext.This is the only context having that limitation.
ThreadLocalSessionContextsupports multiple factories but have a contrived implementation with debatable semantics, such as "auto-opening" a session at first request instead of mandating explicit bind/unbind operations. Its test case is not even activated due to the lack of the "auto-close on transaction end" feature implementation it requires for having its pattern making sense.