NH-3040: SymbolSource support along with NuGet

[TripleEmcoder]

https://nhibernate.jira.com/browse/NH-3040

[patearl]

I didn't actually try it, but it didn't look like this produced two separate packages, one for the source/symbols and one for the binaries. Can you confirm if this is the case and if it doesn't produce separate packages, then split them?

[TripleEmcoder]

Yes, it produced two separate packages: .nupkg and .symbols.nupkg, both for
Iesi.Collections and NHibernate, so a total of 4 packages.

Passing -symbols to nuget.exe pack will always do that, unless you have
something older than 1.5 or 1.4 (don't remember exactly when it was
introduced).

2012/2/2 Patrick Earl <
reply@reply.github.com

I didn't actually try it, but it didn't look like this produced two
separate packages, one for the source/symbols and one for the binaries.
Can you confirm if this is the case and if it doesn't produce separate
packages, then split them?

---

Reply to this email directly or view it on GitHub:
#68 (comment)

[oskarb]

Two (i.e. 4) packages are in fact produced but I'm getting a bunch of warnings similar to this:
[exec] Issue: Incompatible files in lib folder.
[exec] Description: The file 'lib\Net35\NHibernateXmlConfigurationTemplates\MySql.cfg.xml' is not a valid assembly. If it is an XML documentation file or a .pdb file, there is no matching assembly specified in the same folder.
[exec] Solution: Either remove this file from 'lib' folder or add a matching .dll for it.

It is unclean. @TripleEmcoder Can you do something about that please?

[TripleEmcoder]

Well those files were included before, my change did not affect it. You guys are choosing to include those XML files with this directive form NHibernate.build:

   <copy todir="${nuget.workingdir}/NHibernateXmlConfigurationTemplates">
      <fileset basedir="../NHibernate.Config.Templates">
        <include name="*"/>
      </fileset>
    </copy>

[oskarb]

Ah, perhaps it's the updated nuget version which is more explicit about warnings then. Surely there must be some way to avoid the warnings, but I've never worked with nuget.

[TripleEmcoder]

Right, I haven't thought of that - it must be the updated nuget.exe. I am not aware of any way to disable warnings. But they are there for a reason, so maybe you should reevaluate the placement of those files. I think they are rather part of the documentation, and should be skipped there altogether. You could also try one of these:

• change their extension to something else
• put them in content instead of lib (but that will cause them to be copied into the project)
• put them in a custom folder like doc (but that might also issue a warning, as I am not aware of a convention like that)
• ask the NuGet people for a better solution

[TripleEmcoder]

Oops, there is actually a way to disable these warnings: pass -NoPackageAnalysis to nuget.exe.

[oskarb]

I'm not too keen on disabling warnings, so I think one of the other workarounds may be better, Putting the files in e.g. "samples" outside the lib directory does not seem to generate a warning. Maybe one could also argue that it is content (e.g. Content/NHibernate/*).

I'm going to accept your change as is. For now we'll live with the warnings, until this is more well understood.

[TripleEmcoder]

Great, thanks!