Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Popup is triggered on Update event even if useFormPopup is false #1249

Closed
florinleu opened this issue Aug 11, 2022 · 4 comments · Fixed by #1252
Closed

Form Popup is triggered on Update event even if useFormPopup is false #1249

florinleu opened this issue Aug 11, 2022 · 4 comments · Fixed by #1252
Labels
2.0 New versions Bug

Comments

@florinleu
Copy link

Version

2.1.2

Test Environment

Safari, Chrome, macOS 12.5

Current Behavior

Tapping on Edit event in the Detail Popup opens the Form Popup even when useFormPopup is false.

Expected Behavior

Tapping on Edit event in the Detail Popup when useFormPopup is false shouldn't open the Form popup and trigger an event to allow custom action (like opening a custom view).

@adhrinae adhrinae added Bug 2.0 New versions labels Aug 11, 2022
@adhrinae
Copy link
Contributor

@florinleu
You're right. I'll fix and release the patch until next week.

@adhrinae
Copy link
Contributor

@florinleu

The new version is released. Please try it out.

@sabatale
Copy link

sabatale commented Oct 6, 2022

@adhrinae Can you tell me if the following is related to this fix?

With userFormPopup: true, the select/unselect works fine However, when set on false, the user cannot unselect the tile anymore. It just keeps adding color layers. Or is because it's intended to be used in read-only when popups are set to false?

tui_cal_select

@adhrinae
Copy link
Contributor

adhrinae commented Oct 7, 2022

@sabatale
No. the selection feature works accumulatively in the monthly view. But not for the same day. So I recognize this is a bug.

Could you create an issue about this so that we can track the issue easily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 New versions Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants