Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent opening form popup through detail popup when it is disabled #1252

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

adhrinae
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fixed that the default form popup appears even though the useFormPopup option is disabled. because the EventDetailPopup component is calling it ignoring the option.

Resolves #1249.

AS-IS

Screen.Recording.2022-08-12.at.16.10.26.mov

TO-BE

Screen.Recording.2022-08-12.at.16.11.51.mov

Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œν•©λ‹ˆλ‹€.

popupArrowPointPosition,
});
} else {
eventBus.fire('beforeUpdateEvent', { event: event.toEventObject(), changes: {} });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeUpdateEvent μ»€μŠ€ν…€μ΄λ²€νŠΈλŠ” λ­”κ°€ 이벀트λ₯Ό μ‹€μ œλ‘œ μˆ˜μ •ν•  λ•Œ μΌμ–΄λ‚˜μ•Όν•  것 같은데 Edit λ²„νŠΌμ„ λˆ„λ₯΄λ©΄ changes 없이 μ΄λ²€νŠΈκ°€ λ°œμƒν•˜λŠ”κ²Œ 쑰금 μ–΄μƒ‰ν•˜κ²Œ λŠκ»΄μ§‘λ‹ˆλ‹€. μ–΄λ–»κ²Œ μƒκ°ν•˜μ‹œλ‚˜μš”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 μ§€κΈˆ μ½”λ“œλŠ” v1 λ™μž‘κ³Ό λ™μΌν•œ μƒνƒœμž…λ‹ˆλ‹€.
μ œμ•ˆν•œλŒ€λ‘œ μˆ˜μ •ν•˜λ €λ©΄ μ €λŠ” μΈμŠ€ν„΄μŠ€ μ΄λ²€νŠΈκ°€ μƒˆλ‘œ μΆ”κ°€λ˜μ–΄μ•Όν•œλ‹€κ³  λ΄μ„œ, μ΅œλŒ€ν•œ 변경을 적게 λ§Œλ“€μ—ˆμ–΄μš”.

changes 도 μ˜΅μ…”λ„λ‘œ λ§Œλ“€κΉŒ ν–ˆλŠ”λ° 그러면 μ‹ κ²½μ¨μ•Όν• κ²Œ λ„ˆλ¬΄ λ§Žμ•„μ„œ κ·Έλƒ₯ 빈 객체λ₯Ό μ „λ‹¬ν•˜λŠ”κ±°λ‘œ λ°”κΏ¨μŠ΅λ‹ˆλ‹€.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ μ•Œκ² μŠ΅λ‹ˆλ‹€!

@adhrinae adhrinae merged commit eb23820 into main Aug 16, 2022
@adhrinae adhrinae deleted the fix/hide-form-popup branch August 16, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Popup is triggered on Update event even if useFormPopup is false
4 participants