Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readOnly events require two touches to open #1270

Open
Tragio opened this issue Sep 1, 2022 · 7 comments
Open

readOnly events require two touches to open #1270

Tragio opened this issue Sep 1, 2022 · 7 comments
Labels
Enhancement Enhance performance or improve usability of original features. Help Wanted 🤝

Comments

@Tragio
Copy link
Contributor

Tragio commented Sep 1, 2022

Hi team 👋

Using the v2 for some weeks already, everything was smooth. However, I found that when I’m using readOnly events, on a touch device, I need to click two times to open.

When readOnly is disabled, you click one time and then click where you want to rearrange the calendar.

In this case, when readOnly is enabled after the first touch on the event, wherever I click inside the calendar it will open. Clarifying, touching one time and then another time in any area of the calendar will trigger the event.

The best behaviour would be when readOnly is enabled, it requires just one touch.

Really thank you for your awesome work 🙏

@adhrinae adhrinae added the Enhancement Enhance performance or improve usability of original features. label Sep 2, 2022
@adhrinae
Copy link
Contributor

adhrinae commented Sep 2, 2022

@Tragio

I'm not sure what you want to open, but I assume that you want to open the event details popup.

First of all and most important, TUI Calendar doesn't officially support mobile devices. So you need to know that every interaction of the calendar is built for PC.

Since we're not handling any touch events, it might have unexpected behaviors.

(For a more detailed explanation between the mouse event and the touch event, this post is helpful.)

I've tested it on one of my devices(Android 12, Firefox), and it needs two touches to open the popup nevertheless the readOnly option is set or not.

In conclusion, I cannot tell you how and when we will improve this because it's not our priority.

@Tragio
Copy link
Contributor Author

Tragio commented Sep 2, 2022

@adhrinae thank you for your reply.

Yes, you're right.

  1. If you don't have readOnly it makes sense to touch one time and then touch again to move the event to where you want.
  2. If you have readOnly, doesn't make any sense to touch 2 times. Worse, is that you touch one time on the event, and now IF you touch a second time in any area div of the calendar it will trigger that event to open.

I know that you don't support mobile devices, but still, there are so many touch computers nowadays, especially in the industry.

Thank you once again 😄

@Tragio
Copy link
Contributor Author

Tragio commented Sep 10, 2022

@adhrinae came to my mind, if the problem is the mouse event and touch event, why not use pointer event? 🤔

"Pointer events are DOM events that are fired for a pointing device. They are designed to create a single DOM event model to handle pointing input devices such as a mouse, pen/stylus or touch (such as one or more fingers)."

https://caniuse.com/pointer is compatible with 95% of the browsers and if is not available we can callback to the normal mouse event.

if (window.PointerEvent) {}

@adhrinae
Copy link
Contributor

@Tragio

That's a good idea. I haven't thought about that.

@vgavrilovikj
Copy link

Would be great to see this implemented as it is a bit annoying to click 2 times in order for the popup to open.. @adhrinae

@Tragio
Copy link
Contributor Author

Tragio commented Jan 8, 2023

@adhrinae did you had any chance to test that? It would be fantastic to have it in the next version 😄

@adhrinae
Copy link
Contributor

adhrinae commented Jan 9, 2023

@Tragio

Sorry, but there's no update about this issue. 😢
I'll leave the 'Help wanted' label at least someone interested in this issue might resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features. Help Wanted 🤝
Projects
None yet
Development

No branches or pull requests

3 participants