New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong crreation popup position when clicking the "New Schedule" button in "Month" view with hidden weekends #480
Closed
supertrip86 opened this issue
Dec 27, 2019
· 5 comments
· Fixed by #498 or SimHub/simhub-electron-calendar#3
Closed
Wrong crreation popup position when clicking the "New Schedule" button in "Month" view with hidden weekends #480
supertrip86 opened this issue
Dec 27, 2019
· 5 comments
· Fixed by #498 or SimHub/simhub-electron-calendar#3
Comments
@supertrip86 |
Yes, it always an issue.
At the following link the calendar is *currently* working, but only because
we are at the beginning of 2020 and there has been no weekend yet in the
current year. Therefore, it will be working only till next Monday.
https://nhn.github.io/tui.calendar/latest/tutorial-example00-basic
Starting monday 6th of January 2020, if you select "Month" view and hide
the weekends, you will see that clicking on the button "new schedule" is
going to result in wrong positioning of the popup.
It will fail to work again starting next monday. The problem is due to the
fact that the program keeps counting weekend days when calculating where to
insert the popup, even if weekends have been hidden in the calendar, hence
the popup results in being created next to the wrong day.
Let me know if you need further clarifications.
Il giorno ven 3 gen 2020 alle ore 07:55 조정은 <notifications@github.com> ha
scritto:
… @supertrip86 <https://github.com/supertrip86>
Is it always an issue?
Can you give me a Codepen <https://codepen.io/> or jsfiddle
<https://jsfiddle.net/> link to reproduce?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#480?email_source=notifications&email_token=AJWI3TWMMWFB6WGVEA2QGTTQ33OMLA5CNFSM4J77ISA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAN5HI#issuecomment-570482333>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJWI3TU2NC4VCZ2YI4RPMNTQ33OMLANCNFSM4J77ISAQ>
.
|
Reproduced. |
jungeun-cho
added a commit
that referenced
this issue
Jan 29, 2020
…opup were calculated incorrectly if 'workweek = true'(fix #480)
7 tasks
jungeun-cho
added a commit
that referenced
this issue
Jan 30, 2020
…plates fix: fix coordinates in the schedule creation popup(fix #480), docs: fix custom events link, chore: update issue templates
@supertrip86 |
@supertrip86 |
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VERSION:
Latest version, as used on the example page:
https://nhn.github.io/tui.calendar/latest/tutorial-example00-basic
DEVELOPMENT ENVIRONMENT:
Any browser
CURRENT BEHAVIOUR:
When "Month" view is selected and weekends are hidden, clicking on the "new schedule" button causes the creation popup to position on the wrong day (the function counts also weekends, even though they are hidden)
EXPECTED BEHAVIOUR:
The creation popup should be positioned next to the correct day
The text was updated successfully, but these errors were encountered: