Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong crreation popup position when clicking the "New Schedule" button in "Month" view with hidden weekends #480

Closed
supertrip86 opened this issue Dec 27, 2019 · 5 comments · Fixed by #498 or SimHub/simhub-electron-calendar#3

Comments

@supertrip86
Copy link

VERSION:
Latest version, as used on the example page:
https://nhn.github.io/tui.calendar/latest/tutorial-example00-basic

DEVELOPMENT ENVIRONMENT:
Any browser

CURRENT BEHAVIOUR:
When "Month" view is selected and weekends are hidden, clicking on the "new schedule" button causes the creation popup to position on the wrong day (the function counts also weekends, even though they are hidden)

EXPECTED BEHAVIOUR:
The creation popup should be positioned next to the correct day
Untitled

@jungeun-cho
Copy link
Contributor

@supertrip86
Is it always an issue?
Can you give me a Codepen or jsfiddle link to reproduce?

@supertrip86
Copy link
Author

supertrip86 commented Jan 3, 2020 via email

@jungeun-cho
Copy link
Contributor

Reproduced.
If you turn off the weekend view option in the monthly view, I'll check the logic to calculate the date in the day grid.

jungeun-cho added a commit that referenced this issue Jan 29, 2020
…opup were calculated incorrectly if 'workweek = true'(fix #480)
jungeun-cho added a commit that referenced this issue Jan 30, 2020
…plates

fix: fix coordinates in the schedule creation popup(fix #480), docs: fix custom events link, chore: update issue templates
@jungeun-cho
Copy link
Contributor

@supertrip86
It will be patched in v1.12.11.

@jungeun-cho jungeun-cho reopened this Jan 30, 2020
@jungeun-cho
Copy link
Contributor

@supertrip86
Patched in v1.12.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment