Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary global variable #1203

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix: remove unnecessary global variable #1203

merged 1 commit into from
Jul 11, 2022

Conversation

adhrinae
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • this variable was introduced for SSR, but it's not useful at all.
  • also, it breaks the ESM bundle when it's not defined as window.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

* this variable was introduced for SSR, but it's not useful at all.
* also, it breaks the ESM bundle when it's not defined as `window`.
@adhrinae adhrinae merged commit 2976dd3 into main Jul 11, 2022
@adhrinae adhrinae deleted the fix/esm-global branch July 11, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants