Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calibrate 30minutes event height #1206

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Jul 12, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • calibrate short event with going, coming duration

  • AS-IS (30 minutes event with going, coming duration)

스크란샷 2022-07-12 α„‹α…©α„Œα…₯ᆫ 9 40 02

  • TO-BE

스크란샷 2022-07-12 α„‹α…©α„Œα…₯ᆫ 9 41 44


Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

Copy link
Member

@dotaitch dotaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œν•©λ‹ˆλ‹€.

Copy link
Contributor

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œν•©λ‹ˆλ‹€.
컨트둀러의 기본값이 μ΅œμ € 높이 섀정을 λ°©ν•΄ν•˜κ³  μžˆμ–΄μ„œ 생긴 μ΄μŠˆμ˜€λ‚˜λ³΄λ„€μš”.
μ΅œμ’…μ μœΌλ‘œ μ§€κΈˆ λ²„μ „μ˜ λ Œλ”λ§μ΄ 이상이 μ—†λŠ”μ§€, 이틀에 걸쳐 going + coming duration μžˆλŠ” 일정듀도 λ Œλ”λ§μ΄ 잘 λ˜λŠ”μ§€λ§Œ 확인 λΆ€νƒν•©λ‹ˆλ‹€.

apps/calendar/src/controller/column.ts Show resolved Hide resolved
@lja1018 lja1018 merged commit ac759cc into main Jul 12, 2022
@lja1018 lja1018 deleted the fix/calibrate-30minutes-event-height branch July 12, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants