-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/daygrid creation guide #810
Conversation
clientX: 9, | ||
clientY: 20, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄λ κ² ν μ€νΈ νλ€λ³΄λ©΄ UIλ₯Ό μ‘°κΈλ§ λ³κ²½ν΄λ κΈλ°© ν μ€νΈ μΌμ΄μ€κ° κΉ¨μ§ κ² κ°μλ°μ..clientX, clientYλ₯Ό ν΅ν΄ μ΄ λ§μ°μ€ ν¬μΈνΈκ° μ λλ‘ ν΄λ¦λλμ§λ₯Ό μ μΆνκΈ° μ‘°κΈ νλ ν μ€νΈμΈκ² κ°λ€μ..λ€λ₯Έλ°©λ²μ΄ μμκΉμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ν΄λ¦μ΄λ²€νΈ λ°μμ νμΈνλ λͺ©μ μ΄μλλΌ λ§μ°μ€ ν¬μΈνΈ κΈ°μ€μΌλ‘ 그리λμ rowIndex(y), columnIndex(x)λ₯Ό μ λλ‘ κ³μ°νλμ§ νμΈνκ³ μμ΅λλ€~!
@@ -120,3 +128,14 @@ export function includes<T>(arr: T[], searchItem: T, searchIndex?: number) { | |||
|
|||
return false; | |||
} | |||
export function findIndex<T>(arr: T[], predicate: (item: T) => boolean) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄ λΆλΆ μΆκ°νλ건 ν΄λ¦¬νμ μλ£μΌλ €κ³ μΆκ°νλ건κ°μ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ€, μ§μ ꡬνν΄μ μ¬μ©νμ΅λλ€.
store.dispatch('dataStore/clearSchedules', { events }); | ||
|
||
if (events.length) { | ||
store.dispatch('dataStore/createSchedules', { events }); | ||
} | ||
|
||
store.dispatch('dataStore/clearSchedules', { events }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄ λΆλΆμ΄ μ κ° μ λͺ°λΌμ μ΄ν΄κ° λμ§ μλ κ² κ°μλ°
dataStoreμ μ€μΌμ€μ clearνλ€μμ λ€μ μμ±νλ€κ° λ€μ clearνλ건κ°μ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ€ μλ‘μ΄ κ° μ€ν 리λ§λ€ μ΄μ μ μλ μ€ν 리λ₯Ό μ΄κΈ°νν΄μ€λλ€.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μλ£ν©λλ€~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰μλ£ν©λλ€.
const start = toStartOfDay(day); | ||
const end = toEndOfDay(start); | ||
|
||
return { | ||
start, | ||
end, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ°λ‘ 리ν΄ν΄λ λ κ² κ°μμ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endκ° κ³μ°λ startλ₯Ό κΈ°μ€μΌλ‘ κ³μ°ν΄μμγ
end: toEndOfDay(toStartOfDay(day))
λ‘ μμ±ν κΉμκ°νλλ°
λ³μμ λ΄μ μ¬μ©νλκ²μ΄ μ€λ³΅μ μ€μ΄κ³ κ°λ
μ±μ΄ λ μ’λ€κ³ νλ¨ν©λλ€.
@@ -73,6 +72,7 @@ function getStyles({ viewModel, eventHeight, headerHeight, flat = false }: GridE | |||
exceedRight, | |||
model: { bgColor, borderColor }, | |||
} = viewModel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄μ μ 리뷰νλ μ¬νμΈλ viewModel
μ΄ μΌλ°μ μΌλ‘ μκ°νλ λ·°λͺ¨λΈκ³Ό λμΌν μν μ νλκ² λ§λμ§ μκ°ν΄λ΄μΌλ κ² κ°μμ. μ¬μ€μ λ·°μ λͺ¨λΈ μ¬μ΄μ μΈν°νμ΄μ€λ‘μ μν μ μ λλ‘ μννλκ² μλμλ κ±Έλ‘ κΈ°μ΅μ΄ λμμ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ€ νμ¬ viewModelμ λ·°μ λͺ¨λΈμ¬μ΄μ μΈν°νμ΄μ€ μν μ΄ μλλΌ λ λλ§μ μν μΊλ¦°λ λ΄λΆμμ μ¬μ©νλ μ΄λ²€νΈ λͺ¨λΈμ
λλ€.
v1λΆν° μ¬μ©νλ©΄μ κ·Έλλ‘ κ°μ Έμ μ¬μ©λμλλ°μ.
λ€μ΄λ°μ λ°κΏ νμκ° μμκ²κ°μμ. μ΄λΆλΆμ μΊλ¦°λ μμ
μλΆλ€μ΄λ μ΅μ
λͺ
λ
Όμνλ©΄μ ν¨κ» μλ
Όνκ² μ΅λλ€.
@@ -57,6 +58,24 @@ function useContainerHeight(container: Ref<HTMLDivElement>, dayNameHeight: numbe | |||
return gridPanelHeight; | |||
} | |||
|
|||
function usePanelContainer(container: Ref<HTMLDivElement>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄μ μ containerλ₯Ό 컨ν μ€νΈμ λ΄μμ μ΄λ€κ³ νλκ±° κ°μλ° μλκ°μ~?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ¬μ©μκ° μ λ ₯ν 루νΈμμκ° μλλΌ μ»΄ν¬λνΈμμ μ¬μ©λλ μΌλΆλΌμ μ μ₯νμ§ μκ³ μ¬μ©νμ΅λλ€.
triggerEvent: 'click', | ||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
util ν μ€νΈ λ§κ³ UIκΈ°μ€μΌλ‘ ν΅ν©ν μ€νΈλ μλμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing-library/preact-testing-library#38
jestμμ ν΅ν©ν
μ€νΈ μμ±νλ€κ° μμμλ μ€λ₯κ° λ°μν΄μμ.
μ΄μ μ¬λ €λμꡬ, νλ‘μ
νλλ‘ν κ»μ~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 μλ£μ λλ€
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
basic
![αα
³αα
³α
α
΅α«αα
£αΊ 2021-05-20 23 53 59](https://user-images.githubusercontent.com/43128697/119001317-d4377700-b9c6-11eb-9e92-10991c16b7ae.png)
2 weeks
![αα
³αα
³α
α
΅α«αα
£αΊ 2021-05-18 20 26 37](https://user-images.githubusercontent.com/43128697/118643437-84667d80-b817-11eb-9199-9291838f8a40.png)
narrow weekend
![αα
³αα
³α
α
΅α«αα
£αΊ 2021-05-21 00 16 51](https://user-images.githubusercontent.com/43128697/119004860-e2d35d80-b9c9-11eb-9a26-14674d15404c.png)
Thank you for your contribution to TOAST UI product. π π β¨