Fix: use IThemeRange for chart.background option #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
| @@ -80,7 +80,7 @@ declare namespace tuiChart { | |||
| interface IThemeConfig { | |||
| chart?: { | |||
| fontFamily?: string; | |||
| background?: string; | |||
| background?: IThemeRange; | |||
There was a problem hiding this comment.
As the naming of the IThemeRange type is used universally, it seems necessary to change the name.
How about a naming of IThemeBackgroundConfig?
There was a problem hiding this comment.
@dana-c0914 I'll Apply it after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
I updated the IThemeConfig interface to use the existing IThemeRange interface for the chart.background option.
The code was already assuming that the option is of type IThemeRange and not just string and also the docs were showing.