Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve series colors #555

Merged
merged 2 commits into from Feb 5, 2021
Merged

fix: resolve series colors #555

merged 2 commits into from Feb 5, 2021

Conversation

jungeun-cho
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • If the number of series exceeds the number of basic colors provided in the chart, the color index starts again from the beginning.

Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ¦¬λ·°μ™„λ£Œ
κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@jung-han
Copy link
Member

jung-han commented Feb 4, 2021

내일 μ•„λ§ˆ 색상 μ£Όμ‹€ 것 κ°™μ•„μ„œ μ˜€λŠ”κ²ƒ κΉŒμ§€ 이 λΈŒλžœμΉ˜μ—μ„œ μž‘μ—…ν•œ λ‹€μŒμ— λ¨Έμ§€ν•˜λ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

@jungeun-cho jungeun-cho merged commit 088040f into main Feb 5, 2021
@jungeun-cho jungeun-cho deleted the fix/resolve-series-colors branch February 5, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants