Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove settimeout when initialize #558

Merged
merged 2 commits into from Feb 3, 2021

Conversation

jung-han
Copy link
Member

@jung-han jung-han commented Feb 3, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Error Description

const chart = new Chart({ ... });

chart.setData({
  // When calling API immediately after creation
});

image


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jung-han jung-han merged commit b2cdbfc into main Feb 3, 2021
@jung-han jung-han deleted the fix/remove-initialize-setTimeout branch February 3, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant