Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: legend overlap when item text overflows #562

Merged
merged 4 commits into from Feb 10, 2021
Merged

fix: legend overlap when item text overflows #562

merged 4 commits into from Feb 10, 2021

Conversation

jung-han
Copy link
Member

@jung-han jung-han commented Feb 8, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

left

image

right

image

top

image

bottom

image

Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

lja1018
lja1018 approved these changes Feb 9, 2021
View reviewed changes
Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ์™„๋ฃŒ
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

jungeun-cho
jungeun-cho approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฒฌ์—†์Šต๋‹ˆ๋‹ค~ ์ˆ˜๊ณ ํ•˜์…จ์–ด์š”!

apps/chart/src/store/legend.ts Outdated Show resolved Hide resolved
apps/chart/src/store/legend.ts Outdated

function getDefaultLegendSize(params: LegendSizeParam) {
const { verticalAlign, chart, itemHeight, initialWidth, circleLegendVisible } = params;
const restAreaHeight = 100 + (circleLegendVisible ? INITIAL_CIRCLE_LEGEND_WIDTH : 0); // rest area temporary value (yAxis.title + xAxis.height + circleLegendHeight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100์€ ์˜๋ฏธ์žˆ๋Š” ์ƒ์ˆ˜๋กœ ๋ณ€ํ™˜ํ•˜๋Š”๊ฒŒ ์–ด๋–ปํ• ๊นŒ์š”? restAreaHeight๋ฅผ ๊ณ„์‚ฐํ•ด์ฃผ๊ธฐ์œ„ํ•ด INITIAL_CIRCLE_LEGEND_WIDTH๋ฅผ ์‚ฌ์šฉํ–ˆ๋Š”๋ฐ circleLegend์˜ ๋„ˆ๋น„ ๊ธฐ์ค€์œผ๋กœ ๊ณ„์‚ฐ๋˜๋Š”๊ฒŒ ๋งž๋‚˜์š”?~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต circle legend๋Š” ๋†’์ด๋‚˜ ๋„ˆ๋น„๊ฐ€ ๊ฐ™์•„์„œ ๊ทธ๋Œ€๋กœ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์ƒ์ˆ˜๋กœ ๋ณ€๊ฒฝํ•ด์„œ ์‚ฌ์šฉํ• ๊ฒŒ์š”!

@jung-han jung-han merged commit b9ba006 into main Feb 10, 2021
@jung-han jung-han deleted the fix/legend-align branch February 10, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lja1018 lja1018 lja1018 approved these changes

@jungeun-cho jungeun-cho jungeun-cho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jung-han @lja1018 @jungeun-cho