Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infinite height increase with auto options(#551) #568

Merged
merged 3 commits into from Feb 16, 2021
Merged

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

#551


Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responsive ๊ด€๋ จ ์˜ˆ์ œํŒŒ์ผ์—์„œ ์ปจํ…Œ์ด๋„ˆ width, height๊ฐ’ ์ง€์ •ํ•ด์ฃผ๊ณ  ์˜ต์…˜์œผ๋กœ ๋‘˜๋‹ค 'auto' ์ง€์ •ํ•ด์ฃผ๋Š”๊ฒŒ ์–ด๋–ปํ• ๊นŒ์š”?

<div id="chart-area" style="width:90vw; height:90vh;"></div>
const options = {
  chart: { title: 'Monthly Revenue', width: 'auto', height: 'auto' },
  /* ... */
};

apps/chart/src/message.ts Outdated Show resolved Hide resolved
@jung-han jung-han merged commit a273690 into main Feb 16, 2021
@jung-han jung-han deleted the fix/auto-height branch February 16, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants