Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get chart el top, left position after rendering #578

Merged
merged 2 commits into from Feb 18, 2021

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

#559

before

image

after

image


Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ¦¬λ·°μ™„λ£Œ
κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

Comment on lines 157 to 159
setTimeout(() => {
this.applyExportButtonPanelStyle(chart.width);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

render ν•¨μˆ˜μ—μ„œ 지연을 κ±°λŠ”κ²ƒμ€ μœ„ν—˜ν•΄λ³΄μž…λ‹ˆλ‹€.
처음 λ²„νŠΌ 클릭 μ‹œ λ„ˆλΉ„λ₯Ό μΊμ‹œν•΄λ‘κ³  μ‚¬μš©ν•˜λŠ”κ±΄μ–΄λ•Œμš”?

responsive μΌλ•Œλ„ ν…ŒμŠ€νŠΈ λΆ€νƒλ“œλ €μš”. 차트 크기 λ³€κ²½ ν›„ μ •μƒμ μœΌλ‘œ λ‚˜μ˜€λŠ”μ§€λ„μš”~!

Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ¦¬λ·°μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€~!

Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€~ μˆ˜κ³ ν•˜μ…¨μ–΄μš”.

@jung-han jung-han merged commit d434d5c into main Feb 18, 2021
@jung-han jung-han deleted the fix/export-menu-scroll branch February 18, 2021 00:34
@Han-Jiho
Copy link

μ΄κ±°λ•œμ— μ§„λ•€λΊλŠ”λ° κ³ μ³μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€ γ…Žγ……γ…Ž

@jung-han jung-han restored the fix/export-menu-scroll branch February 18, 2021 07:36
@jung-han jung-han deleted the fix/export-menu-scroll branch February 18, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants