Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add types for radialBar chart visible, null data #588

Merged
merged 1 commit into from Feb 19, 2021
Merged

chore: add types for radialBar chart visible, null data #588

merged 1 commit into from Feb 19, 2021

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • add null, visible types for radialBar chart

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

shiren
shiren approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@shiren shiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lja1018
lja1018 approved these changes Feb 19, 2021
View reviewed changes
Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료
고생하셨습니다!

jungeun-cho
jungeun-cho approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@jung-han jung-han merged commit 1289b28 into main Feb 19, 2021
@jung-han jung-han deleted the feat/radarBar-visible branch February 19, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiren shiren shiren approved these changes

@lja1018 lja1018 lja1018 approved these changes

@jungeun-cho jungeun-cho jungeun-cho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jung-han @shiren @lja1018 @jungeun-cho