fix: wrong scroll sync preview position (close #263) (#264)

nhn · Jul 17, 2018 · 093c398 · 093c398
1 parent f783d92
commit 093c398
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/js/extensions/scrollSync/sectionManager.js b/src/js/extensions/scrollSync/sectionManager.js
@@ -291,8 +291,9 @@ class SectionManager {
    */
   _isSeTextHeader(lineString, nextLineString) {
     return lineString.replace(FIND_SPACE, '') !== ''
-            && nextLineString
-            && FIND_SETEXT_HEADER_RX.test(nextLineString);
+      && !this._isQuote(lineString)
+      && nextLineString
+      && FIND_SETEXT_HEADER_RX.test(nextLineString);
   }
 
   _isImage(lineString) {

diff --git a/test/unit/extensions/scrollSync/sectionManager.spec.js b/test/unit/extensions/scrollSync/sectionManager.spec.js
@@ -331,6 +331,21 @@ describe('sectionManager', () => {
       expect(sectionManager.sectionByLine(99999)).toBe(sectionList[2]);
     });
 
+    it('should not create a section for setext heading with quote', () => {
+      ned.setValue([
+        'text',
+        '> quote',
+        '---'
+      ].join('\n'));
+
+      sectionManager.makeSectionList();
+      const sectionList = sectionManager.getSectionList();
+
+      expect(sectionManager.sectionByLine(0)).toBe(sectionList[0]);
+      expect(sectionManager.sectionByLine(1)).toBe(sectionList[0]);
+      expect(sectionManager.sectionByLine(99999)).toBe(sectionList[0]);
+    });
+
     it('create new section of image where at root level', () => {
       ned.setValue([
         'paragraph',