Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent list type replace #208

Closed
kyuwoo-choi opened this issue Jun 15, 2018 · 0 comments
Closed

inconsistent list type replace #208

kyuwoo-choi opened this issue Jun 15, 2018 · 0 comments
Labels
Bug
Milestone
1.2.3

Comments

@kyuwoo-choi
Copy link
Member

Version

Test Environment

Current Behavior

The attempt to change the type from task to ul,ol is failing.
Because it doesn't remove markdown task syntax.
WYSIWYG doesn't remove task class too.

OL

  • * -> OL -> 1.
  • 1. -> OL -> 1.
  • * [ ] -> OL -> 1. [ ]
  • 1. [ ] -> OL -> 1. [ ]

UL

  • * -> UL -> *
  • 1. -> UL -> *
  • * [ ] -> UL -> * [ ]
  • 1. [ ] -> UL -> * [ ]

TASK

  • * -> TASK -> * [ ]
  • 1. -> TASK -> 1. [ ]
  • * [ ] -> TASK -> *
  • 1. [ ] -> TASK -> 1.

Expected Behavior

OL

  • * -> OL -> 1.
  • 1. -> OL -> 1.
  • * [ ] -> OL -> 1.
  • 1. [ ] -> OL -> 1.

UL

  • * -> UL -> *
  • 1. -> UL -> *
  • * [ ] -> UL -> *
  • 1. [ ] -> UL -> *

TASK

  • * -> TASK -> * [ ]
  • 1. -> TASK -> 1. [ ]
  • * [ ] -> TASK -> *
  • 1. [ ] -> TASK -> 1.
@kyuwoo-choi kyuwoo-choi added this to the 1.2.3 milestone Jun 15, 2018
@kyuwoo-choi kyuwoo-choi mentioned this issue Jun 15, 2018
Merged
6 tasks
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@shiren @seonim-ryu
changeBlockFormat, changeBlockFormatTo added resolve #209, resolve #208
224d54e
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@kyuwoo-choi @seonim-ryu
fix: wrong list type change (close #208) (#209)
d399bc7 
* fix: wrong markdown list type change

* fix: wrong wysiwyg list type change

* refactor: apply code review (ref #209)
seonim-ryu pushed a commit that referenced this issue Jan 6, 2020
@kyuwoo-choi @seonim-ryu
fix: wrong list type change (close #208) (#209)
0be8f85 
* fix: wrong markdown list type change

* fix: wrong wysiwyg list type change

* refactor: apply code review (ref #209)
seonim-ryu pushed a commit that referenced this issue Feb 5, 2020
@neilj @seonim-ryu
Merge pull request #208 from eightyeight/patch-2
832a36a 
Make the existence of the NPM package more obvious
seonim-ryu pushed a commit that referenced this issue Feb 5, 2020
@neilj @seonim-ryu
Merge pull request #208 from eightyeight/patch-2
06c3f63 
Make the existence of the NPM package more obvious
js87zz pushed a commit that referenced this issue Jun 17, 2021
@shiren @seonim-ryu
changeBlockFormat, changeBlockFormatTo added resolve #209, resolve #208
f144494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.2.3
Development

No branches or pull requests
1 participant
@kyuwoo-choi