Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<br>\n rendering result is different between preview and wysiwyg #528

Closed
sohee-lee7 opened this issue Jun 5, 2019 · 1 comment · Fixed by OpenTMI/opentmi-default-gui#28 · May be fixed by christian7877/toast-ui.vue-editor#1
Closed

<br>\n rendering result is different between preview and wysiwyg #528

sohee-lee7 opened this issue Jun 5, 2019 · 1 comment · Fixed by OpenTMI/opentmi-default-gui#28 · May be fixed by christian7877/toast-ui.vue-editor#1
Assignees
@sohee-lee7
Labels
Bug Category: Convertor Category: Markdown Syntax NHN P 2
Milestone
1.4.6

Comments

@sohee-lee7
Copy link
Contributor

sohee-lee7 commented Jun 5, 2019 •
edited

Version

v1.4.1

Test Environment

Chrome

Current Behavior

image

If a new line is inserted in table of Markdown, the rendering result is not changed.

image

But when mode is changed to Wysiwyg, the new line makes a new row in the table.

Expected Behavior

The preview of markdown and Wysiwyg should be same.
@sohee-lee7 sohee-lee7 modified the milestones: 1.4.2, 1.4.3 Jun 5, 2019
@sohee-lee7 sohee-lee7 self-assigned this Jun 5, 2019
@sohee-lee7 sohee-lee7 changed the title <br>\n rendering to <br> <br>\n rendering result is different preview and wysiwyg Jun 19, 2019
@sohee-lee7 sohee-lee7 changed the title <br>\n rendering result is different preview and wysiwyg <br>\n rendering result is different between preview and wysiwyg Jun 19, 2019
sohee-lee7 pushed a commit that referenced this issue Jun 19, 2019
fix: rendering is different between preview and wysiwyg (fix: #528)
8da09d0
kishorethecoder pushed a commit to kishorethecoder/tui.editor that referenced this issue Jul 11, 2019
@kishorethecoder
fix: rendering is different between preview and wysiwyg (fix: nhn#528)
451cc17
@seonim-ryu seonim-ryu reopened this Aug 9, 2019
@seonim-ryu
Copy link
Member

seonim-ryu commented Aug 9, 2019 •
edited

gfm behavior

<br> on table

h1 h2
a
b
c
d

<br> on text

1
2


3

4


5

@seonim-ryu seonim-ryu mentioned this issue Aug 11, 2019
Closed
@seonim-ryu seonim-ryu modified the milestones: 1.4.4, 1.4.6 Aug 11, 2019
@seonim-ryu seonim-ryu mentioned this issue Aug 12, 2019
Merged
6 tasks
kishorethecoder added a commit to kishorethecoder/tui.editor that referenced this issue Dec 4, 2019
@kishorethecoder
Revert "fix: rendering is different between preview and wysiwyg (fix: n…
dc1a4fe 
…hn#528)"

This reverts commit 451cc17.
kishorethecoder added a commit to kishorethecoder/tui.editor that referenced this issue Dec 4, 2019
@kishorethecoder
Revert "fix: rendering is different between preview and wysiwyg (fix: n…
607b254 
…hn#528)"

This reverts commit 451cc17.
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@seonim-ryu
fix: rendering is different between preview and wysiwyg (fix: #528)
08e0e4b
seonim-ryu pushed a commit that referenced this issue Jan 6, 2020
@seonim-ryu
fix: rendering is different between preview and wysiwyg (fix: #528)
8a02875
@snyk-bot snyk-bot mentioned this issue Mar 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohee-lee7 sohee-lee7

Labels
Bug Category: Convertor Category: Markdown Syntax NHN P 2
Projects
None yet
Milestone
1.4.6
2 participants
@seonim-ryu @sohee-lee7